Fix handling of arrays in two-argument ranges::distance
#2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.... which was broken by LWG-3392. This implements the proposed resolution of a submitted-but-not-yet-numbered LWG issue.
miscco
reviewed
Jan 23, 2022
miscco
approved these changes
Jan 23, 2022
miscco
reviewed
Jan 23, 2022
| @@ -3474,9 +3474,19 @@ namespace vso1121031 { | |||
| STATIC_ASSERT(!has_member_value_type<indirectly_readable_traits<iterish<float const volatile>>>); | |||
| } // namespace vso1121031 | |||
|
|
|||
| constexpr bool test_lwg_XXX() { | |||
| int a[3] = {}; | |||
There was a problem hiding this comment.
Maybe add another const array for my paranoia
CaseyCarter
commented
Jan 23, 2022
| @@ -3474,9 +3474,19 @@ namespace vso1121031 { | |||
| STATIC_ASSERT(!has_member_value_type<indirectly_readable_traits<iterish<float const volatile>>>); | |||
| } // namespace vso1121031 | |||
|
|
|||
| constexpr bool test_lwg_XXX() { | |||
There was a problem hiding this comment.
I'd like to annotate (here and in the header) with the proper issue number before merging.
|
Converted to draft after Tim pointed out some issues with the PR. |
Quuxplusone
added a commit
to llvm/llvm-project
that referenced
this pull request
Jan 31, 2022
This includes an experimental workaround for LWG3664 "LWG3392 broke std::ranges::distance(a, a+3)", but the workaround may be incomplete, I'm not sure. This should be re-audited when LWG3664 is actually adopted, to see if we need to change anything about our implementation. See also microsoft/STL#2500 Differential Revision: https://reviews.llvm.org/D117940
|
This PR was superseded by #2522. |
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
This includes an experimental workaround for LWG3664 "LWG3392 broke std::ranges::distance(a, a+3)", but the workaround may be incomplete, I'm not sure. This should be re-audited when LWG3664 is actually adopted, to see if we need to change anything about our implementation. See also microsoft/STL#2500 Differential Revision: https://reviews.llvm.org/D117940
arichardson
pushed a commit
to CTSRD-CHERI/llvm-project
that referenced
this pull request
Jan 3, 2023
This includes an experimental workaround for LWG3664 "LWG3392 broke std::ranges::distance(a, a+3)", but the workaround may be incomplete, I'm not sure. This should be re-audited when LWG3664 is actually adopted, to see if we need to change anything about our implementation. See also microsoft/STL#2500 Differential Revision: https://reviews.llvm.org/D117940
bsdjhb
pushed a commit
to CTSRD-CHERI/libcxx
that referenced
this pull request
Jan 4, 2023
This includes an experimental workaround for LWG3664 "LWG3392 broke std::ranges::distance(a, a+3)", but the workaround may be incomplete, I'm not sure. This should be re-audited when LWG3664 is actually adopted, to see if we need to change anything about our implementation. See also microsoft/STL#2500 Differential Revision: https://reviews.llvm.org/D117940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.... which was broken by LWG-3392. This implements the proposed resolution of a submitted-but-not-yet-numbered LWG issue.